Thread (18 messages) 18 messages, 4 authors, 2024-03-19

Re: [PATCH v2 1/1] config: learn the "hostname:" includeIf condition

From: Ignacio Encinas Rubio <hidden>
Date: 2024-03-16 16:50:53


On 16/3/24 17:01, Taylor Blau wrote:
Hi Ignacio,

On Sat, Mar 09, 2024 at 07:18:28PM +0100, Ignacio Encinas wrote:
quoted
---
 Documentation/config.txt  |  9 +++++++++
 config.c                  | 17 ++++++++++++++++
 t/t1305-config-include.sh | 42 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 68 insertions(+)
I took a look at this patch and felt that it was all very sensible. I
left one comment in reply to the sub-thread with you and Peff with some
minor suggestions on the documentation.

Otherwise, the code changes here all look reasonable to me.
Thanks for the review!
 
Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help