Re: [PATCH v2 1/1] config: learn the "hostname:" includeIf condition
From: Taylor Blau <hidden>
Date: 2024-03-16 16:01:34
From: Taylor Blau <hidden>
Date: 2024-03-16 16:01:34
Hi Ignacio, On Sat, Mar 09, 2024 at 07:18:28PM +0100, Ignacio Encinas wrote:
--- Documentation/config.txt | 9 +++++++++ config.c | 17 ++++++++++++++++ t/t1305-config-include.sh | 42 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 68 insertions(+)
I took a look at this patch and felt that it was all very sensible. I left one comment in reply to the sub-thread with you and Peff with some minor suggestions on the documentation. Otherwise, the code changes here all look reasonable to me. Thanks, Taylor