Thread (58 messages) 58 messages, 4 authors, 2023-12-28

Re: [PATCH v2 05/11] reftable/stack: perform auto-compaction with transactional interface

From: Taylor Blau <hidden>
Date: 2023-12-08 22:14:49

On Fri, Dec 08, 2023 at 03:53:14PM +0100, Patrick Steinhardt wrote:
[...] It can thus happen quite fast that the stack grows very long, which
results in performance issues when trying to read records.
This sentence was a little confusing to read at first glance. Perhaps
instead:

    The stack can grow to become quite long rather quickly, leading to
    performance issues when trying to read records.
But besides
performance issues, this can also lead to exhaustion of file descriptors
very rapidly as every single table requires a separate descriptor when
opening the stack.
Well explained, thanks. Everything else here looks good to me.

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help