Thread (26 messages) 26 messages, 2 authors, 2023-11-10

Re: [PATCH v3 1/3] t/lib-httpd: dynamically detect httpd and modules path

From: Jeff King <hidden>
Date: 2023-11-09 07:48:33

On Thu, Nov 09, 2023 at 08:36:53AM +0100, Patrick Steinhardt wrote:
quoted
Sorry to be a pedant, but I'm not sure if we might have portability
problems with "-a". It's an XSI extension, and POSIX labels it as
obsolescent because it can create parsing ambiguities.

We do have a few instances, but only in corners of the test suite that
probably don't get as much exposure (t/perf and valgrind/valgrind.sh).
So maybe not worth worrying about, but it's easy to write it as:
Yeah, I was grepping for it in our codebase and saw other occurrences,
so I assumed it was fair game. If we're going to convert it to the
below, how about I send another patch on top that also converts the
preexisting instances so that the next one grepping for it isn't going
to repeat the same mistake?
I would be very happy with that. :)

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help