Re: [PATCH v3 3/3] t9164: fix inability to find basename(1) in Subversion hooks
From: Jeff King <hidden>
Date: 2023-11-09 07:35:19
From: Jeff King <hidden>
Date: 2023-11-09 07:35:19
On Thu, Nov 09, 2023 at 08:10:01AM +0100, Patrick Steinhardt wrote:
+ # Subversion hooks run with an empty environment by default. We thus
+ # need to propagate PATH so that we can find executables.
+ cat >"$rawsvnrepo/conf/hooks-env" <<-EOF
+ [default]
+ PATH = ${PATH}
+ EOF
This is so much less ugly than the shell shenanigans discussed in the
earlier round. Thanks for finding it. :)
The ${PATH} here is interpolated by the here-doc. I guess it's possible
somebody's exotic PATH could break the svn conf syntax, but it's
probably not worth worrying about.
-Peff