Re: [PATCH v2 03/12] builtin/show-ref: fix leaking string buffer
From: Taylor Blau <hidden>
Date: 2023-10-30 18:10:42
From: Taylor Blau <hidden>
Date: 2023-10-30 18:10:42
On Thu, Oct 26, 2023 at 11:56:29AM +0200, Patrick Steinhardt wrote:
Fix a leaking string buffer in `git show-ref --exclude-existing`. While the buffer is technically not leaking because its variable is declared as static, there is no inherent reason why it should be.
Well spotted and fixed. I ran the test suite in GIT_TEST_PASSING_SANITIZE_LEAK's "check" mode and didn't find anything that was made leak-free by this patch not already marked as such. So this (and the rest of the series up to this point) LGTM. Thanks, Taylor