Thread (59 messages) 59 messages, 3 authors, 2023-10-31

Re: [PATCH 04/12] builtin/show-ref: fix dead code when passing patterns

From: Eric Sunshine <hidden>
Date: 2023-10-24 18:02:30

On Tue, Oct 24, 2023 at 9:10 AM Patrick Steinhardt [off-list ref] wrote:
When passing patterns to `git show-ref` we have some code that will
cause us to die of `verify && !quiet` is true. But because `verify`
s/of/if/
indicates a different subcommand of git-show-ref(1) that causes us to
execute `cmd_show_ref__verify()` and not `cmd_show_ref__patterns()`, the
condition cannot ever be true.

Let's remove this dead code.

Signed-off-by: Patrick Steinhardt <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help