Thread (61 messages) 61 messages, 2 authors, 2023-10-20

Re: [PATCH 03/20] midx: stop ignoring malformed oid fanout chunk

From: Jeff King <hidden>
Date: 2023-10-11 22:52:51

On Tue, Oct 10, 2023 at 07:50:31PM -0400, Taylor Blau wrote:
All makes sense. I have a mild preference for "missing or corrupt" over
"missing or corrupted", but it's mild enough that I wouldn't be sad if
you kept it as-is ;-).
Hmm, now I wonder which is grammatically more appropriate.

According to the internet (which is never wrong), the distinction is
generally one of intrinsic corrupt state versus something that has
become corrupted. So I guess it depends on whether the file was created
corrupt by a bug or corrupted by a hard disk failure. ;)

I do not have a strong preference myself. The commits went into next
already, but I think you also pointed out that many of these could be
marked for translation (though this one is already).

So we could do one or two patches to adjust the error messages on top.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help