Thread (61 messages) 61 messages, 2 authors, 2023-10-20

Re: [PATCH 08/20] midx: enforce chunk alignment on reading

From: Taylor Blau <hidden>
Date: 2023-10-11 14:56:47

On Mon, Oct 09, 2023 at 05:05:23PM -0400, Jeff King wrote:
---
 chunk-format.c              |  8 +++++++-
 chunk-format.h              |  3 ++-
 commit-graph.c              |  2 +-
 midx.c                      |  3 ++-
 t/t5319-multi-pack-index.sh | 14 ++++++++++++++
 5 files changed, 26 insertions(+), 4 deletions(-)
Very nicely written and explained. I agree that the choice you made here
(to validate the alignment in the chunk-format API itself when reading
the table of contents) feels more sensible and places less burden on the
callers.

LGTM, let's keep reading...

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help