On Tue, Sep 26, 2023 at 4:48 PM Oswald Buddenhagen
[off-list ref] wrote:

quoted

Jiang Xin [off-list ref] writes:

quoted

+++ b/pkt-line.c

@@ -462,8 +462,33 @@ enum packet_read_status packet_read_with_status(int fd, char **src_buffer,
     }
+                    case 2:
+                            /* fallthrough */
+                    case 3:

while not entirely unprecedented, it's unnecessary and even
counter-productive to annotate directly adjacent cases with fallthrough.

I see in "blame.c" there are directly adjacent cases like below. I
will remove the fallthrough statement.

        case 'A':
        case 'T':
                /* Did not exist in parent, or type changed */
                break;

Thanks.