Thread (11 messages) 11 messages, 3 authors, 2023-12-17

Re: [PATCH v2 3/3] pkt-line: do not chomp newlines for sideband messages

From: Oswald Buddenhagen <hidden>
Date: 2023-09-26 08:48:14

Possibly related (same subject, not in this thread)

Jiang Xin [off-list ref] writes:
quoted
+++ b/pkt-line.c
@@ -462,8 +462,33 @@ enum packet_read_status packet_read_with_status(int fd, char **src_buffer,
 	}
+			case 2:
+				/* fallthrough */
+			case 3:
while not entirely unprecedented, it's unnecessary and even 
counter-productive to annotate directly adjacent cases with fallthrough.

regards
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help