Thread (7 messages) 7 messages, 4 authors, 2023-06-06

Re: git push --quiet is not quiet

From: Jeff King <hidden>
Date: 2023-06-06 01:57:30

On Mon, Jun 05, 2023 at 07:36:25AM -0400, Taylor Blau wrote:
I mentioned this to the team that is working on spokes-receive-pack, and
they have graciously implemented support for the quiet capability here:

  https://github.com/github/spokes-receive-pack/pull/49

Hopefully that gets merged and rolled out soon, at which point I think
we can call it a day here.
Ah, cool, I didn't realize the implementation was open source. That pull
request looks like what I'd expect (from my obviously brief look at the
code).

I wondered that it did not pass along any kind of "quiet" designation to
the hooks (who might want to be less chatty in that case). But it
doesn't look like git-receive-pack does, either. So at least
spokes-receive-pack will be on par with git.git. :)

I do think it would be a potentially useful feature for receive-pack to
pass on the information that it got a "quiet" capability request from
the client (probably through the environment). But if people aren't
complaining about it, it's probably not a high priority.  The only
discussion I could find was this thread from a few years ago:

  https://lore.kernel.org/git/ba70b25b-906c-0117-2594-c606595c6816@redhat.com/ (local)

but it didn't result in a patch (the code change itself is probably a
one-liner setenv(), but we'd want documentation, tests, etc).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help