Thread (7 messages) 7 messages, 4 authors, 2023-06-06

Re: git push --quiet is not quiet

From: Jeff King <hidden>
Date: 2023-05-19 20:42:15

On Fri, May 19, 2023 at 11:09:37AM +0200, Hanno Böck wrote:
quoted
So I think this is a bug / lack of feature in GitHub's server
implementation.  It used to be a thin proxy around Git (and Git has
supported "quiet" since c207e34f7733 in 2012). But I suspect they may
have recently replaced it with something more custom (based on the
agent field).
Ok, interesting. Maybe add to this: it appears github sometimes uses
this channel to send relevant messages, e.g. dependabot alerts. Which I
guess is a good thing, but it probably shouldn't send status messages
for normal commits when the user asks for "quiet".
Yeah, that makes sense. Hooks should respect the "quiet" flag, too, as
appropriate. But the problem here is that because the server does not
claim to support the "quiet" capability, the client is not even passing
along the message that the user asked for "--quiet".

Presumably once that is fixed, the custom messages from the server would
then respect the quiet flag. But it's possible there might be more work
needed there, too.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help