Thread (22 messages) 22 messages, 3 authors, 2023-06-09

Re: [PATCH v3 2/2] builtin/pack-objects.c: introduce `pack.recentObjectsHook`

From: Taylor Blau <hidden>
Date: 2023-05-15 20:15:45

On Fri, May 12, 2023 at 12:58:53AM -0400, Jeff King wrote:
I haven't looked closely at this whole patch yet (and I especially want
to look at the new tests since this approach covers more cases), but I
did notice that this version of the function still has the "we don't
reap the child on parse failure" problem I described in:

  https://lore.kernel.org/git/20230505221921.GE3321533@coredump.intra.peff.net/ (local)
Hmmph. I could have sworn that I remember including that feedback in the
new round, but I must have dropped it on the floor somewhere.

Thanks for pointing it out, I'm 99% sure that it'll be in the next round
;-).

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help