Re: [PATCH v3 2/2] builtin/pack-objects.c: introduce `pack.recentObjectsHook`
From: Jeff King <hidden>
Date: 2023-05-12 21:46:23
From: Jeff King <hidden>
Date: 2023-05-12 21:46:23
On Fri, May 12, 2023 at 05:36:15PM -0400, Taylor Blau wrote:
quoted
I suspect both could be fixed by having git-prune trigger the same add_unseen_recent_objects_to_traversal() call either as part of the perform_reachability_traversal() walk, or maybe in its own walk (I think maybe it has to be its own because the second walk should avoid complaining about missing objects).I might be missing something, but I think we already (kind of) do the right thing here. AFAICT, the path is: - cmd_prune() - for_each_loose_file_in_objdir() - prune_object() (as a callback to the above) - is_object_reachable() - perform_reachability_traversal() - mark_reachable_objects() - add_unseen_recent_objects_to_traversal() That only happens when `mark_recent != 0`, though.
Yeah, I'm sorry, I was totally wrong here. See the mail I just sent that crossed paths with yours. -Peff