Re: [PATCH 3/4] tests: drop here-doc check from internal chain-linter
From: Eric Sunshine <hidden>
Date: 2023-03-29 06:29:16
Possibly related (same subject, not in this thread)
- 2023-03-28 · [PATCH 3/4] tests: drop here-doc check from internal chain-linter · Jeff King <hidden>
On Wed, Mar 29, 2023 at 2:07 AM Jeff King [off-list ref] wrote:
On Tue, Mar 28, 2023 at 11:46:37PM -0400, Eric Sunshine wrote:quoted
The attached patch seems to do the job. Apologies for Gmail messing up the whitespace. It's also attached to the email.Thanks! I was going to say "please don't consider this urgent", but I see that my nerd-snipe was successful. ;)
As always. My nerd-snipe armor is in failure mode.
quoted
This would probably make a good preparatory patch to your [3/4]. As mentioned earlier in the thread, the changes to scan_heredoc_tag () capture the input-stream position of the here-doc tag itself, which is necessary since it would be too late to do so by the time the error is detected by swallow_heredocs(). I don't now when I'll get time to send this as a proper patch, so feel free to write a commit message and incorporate it into your series if you want to use it. And, of course, you have my sign-off already in the patch. It should be easy to add a test, as well, in t/chainlint, perhaps as unclosed-here-doc.{text,expect}.Thanks, I can take it from here (and I agree doing it as prep for 3/4 is good, as I can then omit a bunch of explanations there). Here are the tests I'll squash in (along with your $indent fix):
Thanks for picking this up.
quoted hunk ↗ jump to hunk
diff --git a/t/chainlint/unclosed-here-doc-indent.expect b/t/chainlint/unclosed-here-doc-indent.expect diff --git a/t/chainlint/unclosed-here-doc-indent.test b/t/chainlint/unclosed-here-doc-indent.test diff --git a/t/chainlint/unclosed-here-doc.expect b/t/chainlint/unclosed-here-doc.expect diff --git a/t/chainlint/unclosed-here-doc.test b/t/chainlint/unclosed-here-doc.test
The new tests look fine.