Thread (10 messages) 10 messages, 3 authors, 2023-03-29

Re: [PATCH 3/4] tests: drop here-doc check from internal chain-linter

From: Eric Sunshine <hidden>
Date: 2023-03-29 04:02:46

Possibly related (same subject, not in this thread)

On Tue, Mar 28, 2023 at 11:46 PM Eric Sunshine [off-list ref] wrote:
The attached patch seems to do the job. Apologies for Gmail messing up
the whitespace. It's also attached to the email.

     $tag =~ s/['"\\]//g;
-    push(@{$self->{heretags}}, $indented ? "\t$tag" : "$tag");
+    $$token[0] = "\t$tag" if $indented;
+    push(@{$self->{heretags}}, $token);
     return "<<$indented$tag";
Bah, the `$$token[0] = ...` line is incorrect. It should be:

     $$token[0] = $indented ? "\t$tag" : "$tag";

which more correctly matches the original code. Without this fix,
$$token[0] only gets the cleaned tag name in the `<<-EOF` case but not
in the plain `<<EOF` case.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help