Re: [PATCH v2] pipe_command(): mark stdin descriptor as non-blocking

On Wed, Aug 03, 2022 at 06:45:23PM +0200, René Scharfe wrote:

quoted

+test_expect_success 'handle very large filtered diff' '
+	git reset --hard &&
+	# The specific number here is not important, but it must
+	# be large enough that the output of "git diff --color"
+	# fills up the pipe buffer. 10,000 results in ~200k of
+	# colored output.
+	test_seq 10000 >test &&
+	false &&

Isn't this test going to end here, reporting failure before it even gets
to the interesting part?

Urgh, whoops. That was from some last-minute tweaking of the comment.
There was also a line:

  git diff --color | wc -c

before it so I could measure how big the output was for a few values.

It snuck into the emailed patch, but the actual test runs (including the
Windows CI) didn't include that (since obviously they'd have failed the
test).

Thanks for catching.

-Peff