Re: [PATCH v2] pipe_command(): mark stdin descriptor as non-blocking
From: René Scharfe <hidden>
Date: 2022-08-03 16:46:01
Am 03.08.22 um 05:53 schrieb Jeff King:
quoted hunk ↗ jump to hunk
diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh index b354fb39de..01d6ce9c83 100755 --- a/t/t3701-add-interactive.sh +++ b/t/t3701-add-interactive.sh@@ -766,6 +766,20 @@ test_expect_success 'detect bogus diffFilter output' ' force_color test_must_fail git add -p <y ' +test_expect_success 'handle very large filtered diff' ' + git reset --hard && + # The specific number here is not important, but it must + # be large enough that the output of "git diff --color" + # fills up the pipe buffer. 10,000 results in ~200k of + # colored output. + test_seq 10000 >test && + false &&
Isn't this test going to end here, reporting failure before it even gets to the interesting part?
+ test_config interactive.diffFilter cat && + printf y >y && + force_color git add -p >output 2>&1 <y && + git diff-files --exit-code -- test +' + test_expect_success 'diff.algorithm is passed to `git diff-files`' ' git reset --hard &&