[PATCH v3 1/6] bisect.c: add missing "goto" for release_revisions()

[PATCH 0/6] revisions API: fix more memory leaks · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-13
[PATCH 1/6] bisect.c: add missing "goto" for release_revisions() · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-13
[PATCH 2/6] test-fast-rebase helper: use release_revisions() (again) · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-13
[PATCH 3/6] log: make the intent of cmd_show()'s "rev.pending" juggling clearer · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-13
Re: [PATCH 3/6] log: make the intent of cmd_show()'s "rev.pending" juggling clearer · Jeff King <hidden> · 2022-07-18
[PATCH 4/6] log: fix common "rev.pending" memory leak in "git show" · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-13
Re: [PATCH 4/6] log: fix common "rev.pending" memory leak in "git show" · Jeff King <hidden> · 2022-07-18
Re: [PATCH 4/6] log: fix common "rev.pending" memory leak in "git show" · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-18
[PATCH 5/6] bisect.c: partially fix bisect_rev_setup() memory leak · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-13
Re: [PATCH 5/6] bisect.c: partially fix bisect_rev_setup() memory leak · Jeff King <hidden> · 2022-07-18
[PATCH 6/6] revisions API: don't leak memory on argv elements that need free()-ing · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-13
Re: [PATCH 6/6] revisions API: don't leak memory on argv elements that need free()-ing · Jeff King <hidden> · 2022-07-18
Re: [PATCH 6/6] revisions API: don't leak memory on argv elements that need free()-ing · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-18
Re: [PATCH 6/6] revisions API: don't leak memory on argv elements that need free()-ing · Jeff King <hidden> · 2022-07-18
Re: [PATCH 6/6] revisions API: don't leak memory on argv elements that need free()-ing · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-29
Re: [PATCH 6/6] revisions API: don't leak memory on argv elements that need free()-ing · Jeff King <hidden> · 2022-07-29
Re: [PATCH 6/6] revisions API: don't leak memory on argv elements that need free()-ing · Jeff King <hidden> · 2022-07-29
Re: [PATCH 0/6] revisions API: fix more memory leaks · Jeff King <hidden> · 2022-07-18
[PATCH v2 0/6] revisions API: fix more memory leaks · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-29
[PATCH v2 1/6] bisect.c: add missing "goto" for release_revisions() · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-29
[PATCH v2 2/6] test-fast-rebase helper: use release_revisions() (again) · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-29
Re: [PATCH v2 2/6] test-fast-rebase helper: use release_revisions() (again) · Eric Sunshine <hidden> · 2022-07-30
[PATCH v2 3/6] log: make the intent of cmd_show()'s "rev.pending" juggling clearer · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-29
[PATCH v2 4/6] log: fix common "rev.pending" memory leak in "git show" · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-29
Re: [PATCH v2 4/6] log: fix common "rev.pending" memory leak in "git show" · Jeff King <hidden> · 2022-07-29
Re: [PATCH v2 4/6] log: fix common "rev.pending" memory leak in "git show" · Jeff King <hidden> · 2022-07-29
Re: [PATCH v2 4/6] log: fix common "rev.pending" memory leak in "git show" · Jeff King <hidden> · 2022-07-29
[PATCH v2 5/6] bisect.c: partially fix bisect_rev_setup() memory leak · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-29
[PATCH v2 6/6] revisions API: don't leak memory on argv elements that need free()-ing · Ævar Arnfjörð Bjarmason <hidden> · 2022-07-29
Re: [PATCH v2 6/6] revisions API: don't leak memory on argv elements that need free()-ing · Jeff King <hidden> · 2022-07-29
Re: [PATCH v2 0/6] revisions API: fix more memory leaks · Jeff King <hidden> · 2022-07-29
[PATCH v3 0/6] revisions API: fix more memory leaks · Ævar Arnfjörð Bjarmason <hidden> · 2022-08-02
[PATCH v3 1/6] bisect.c: add missing "goto" for release_revisions() · Ævar Arnfjörð Bjarmason <hidden> · 2022-08-02
[PATCH v3 2/6] test-fast-rebase helper: use release_revisions() (again) · Ævar Arnfjörð Bjarmason <hidden> · 2022-08-02
[PATCH v3 3/6] log: fix a memory leak in "git show <revision>..." · Ævar Arnfjörð Bjarmason <hidden> · 2022-08-02
Re: [PATCH v3 3/6] log: fix a memory leak in "git show <revision>..." · Jeff King <hidden> · 2022-08-03
Re: [PATCH v3 3/6] log: fix a memory leak in "git show <revision>..." · Jeff King <hidden> · 2022-08-03
[PATCH v3 5/6] bisect.c: partially fix bisect_rev_setup() memory leak · Ævar Arnfjörð Bjarmason <hidden> · 2022-08-02
[PATCH v3 4/6] log: refactor "rev.pending" code in cmd_show() · Ævar Arnfjörð Bjarmason <hidden> · 2022-08-02
Re: [PATCH v3 4/6] log: refactor "rev.pending" code in cmd_show() · Jeff King <hidden> · 2022-08-03
[PATCH v3 6/6] revisions API: don't leak memory on argv elements that need free()-ing · Ævar Arnfjörð Bjarmason <hidden> · 2022-08-02
Re: [PATCH v3 0/6] revisions API: fix more memory leaks · Jeff King <hidden> · 2022-08-03

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2022-08-02 15:33:29
Subsystem: the rest · Maintainer: Linus Torvalds

Add a missing "goto cleanup", this fixes a bug in
f196c1e908d (revisions API users: use release_revisions() needing
REV_INFO_INIT, 2022-04-13).

Signed-off-by: Ævar Arnfjörð Bjarmason <redacted>
---
 bisect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bisect.c b/bisect.c
index b63669cc9d7..421470bfa59 100644
--- a/bisect.c
+++ b/bisect.c

@@ -1054,7 +1054,7 @@ enum bisect_error bisect_next_all(struct repository *r, const char *prefix)
 		 */
 		res = error_if_skipped_commits(tried, NULL);
 		if (res < 0)
-			return res;
+			goto cleanup;
 		printf(_("%s was both %s and %s\n"),
 		       oid_to_hex(current_bad_oid),
 		       term_good,

-- 
2.37.1.1233.ge8b09efaedc

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help