Re: gc/submodule-use-super-prefix & ab/submodule-cleanup (was: What's cooking in git.git (Jul 2022, #01; Fri, 1))

Ævar Arnfjörð Bjarmason [off-list ref] writes:

On Fri, Jul 01 2022, Junio C Hamano wrote:

quoted

* gc/submodule-use-super-prefix (2022-06-30) 8 commits
 - submodule--helper: remove display path helper
 - submodule--helper update: use --super-prefix
 - submodule--helper: remove unused SUPPORT_SUPER_PREFIX flags
 - submodule--helper: use correct display path helper
 - submodule--helper: don't recreate recursive prefix
 - submodule--helper update: use display path helper
 - submodule--helper tests: add missing "display path" coverage
 - Merge branch 'ab/submodule-cleanup' into gc/submodule-use-super-prefix
 (this branch uses ab/submodule-cleanup.)

 Another step to rewrite more parts of "git submodule" in C.

 Will merge to 'next'?
 source: [ref]

[...]

quoted

* ab/submodule-cleanup (2022-06-28) 12 commits
 - git-sh-setup.sh: remove "say" function, change last users
 - git-submodule.sh: use "$quiet", not "$GIT_QUIET"
 - submodule--helper: eliminate internal "--update" option
 - submodule--helper: understand --checkout, --merge and --rebase synonyms
 - submodule--helper: report "submodule" as our name in some "-h" output
 - submodule--helper: rename "absorb-git-dirs" to "absorbgitdirs"
 - submodule update: remove "-v" option
 - submodule--helper: have --require-init imply --init
 - git-submodule.sh: remove unused top-level "--branch" argument
 - git-submodule.sh: make the "$cached" variable a boolean
 - git-submodule.sh: remove unused $prefix variable
 - git-submodule.sh: remove unused sanitize_submodule_env()
 (this branch is used by gc/submodule-use-super-prefix.)

 Further preparation to turn git-submodule.sh into a builtin.

 Will merge to 'next'.
 source: [ref]

Thanks, with regards to gc/submodule-use-super-prefix that series gets
my enthusiastic (if it helps):

	Reviewed-by: Ævar Arnfjörð Bjarmason [off-list ref]

Likewise the ab/submodule-cleanup parent topic has Glen's:

	Reviewed-by: Glen Choo [off-list ref]

Per [1] and [2]. I.e. the latest is the v4, but the Reviewed-By was
given to v3 in [1], and [4] notes on v4 that the one remaining concern
was addressed.

Thanks both, it's great to see us this close to getting rid of another
*.sh built-in. I plan to submit the migration to the builtin/submodule.c
after these two land, possibly after some memory leak fixes to
builtin/submodule--helper.c.

1. https://lore.kernel.org/git/kl6lh74aivc6.fsf@chooglen-macbookpro.roam.corp.google.com/ (local)
2. https://lore.kernel.org/git/kl6l1qv8ivcs.fsf@chooglen-macbookpro.roam.corp.google.com/ (local)

Yup, I think this is an accurate summary of both topics.

Likewise, I'm really excited to get rid of another *.sh built-in.
Thanks!