Re: [PATCH v4 00/12] submodule: make "git submodule--helper" behave like "git submodule"
From: Glen Choo <hidden>
Date: 2022-06-28 16:54:55
From: Glen Choo <hidden>
Date: 2022-06-28 16:54:55
Ævar Arnfjörð Bjarmason [off-list ref] writes:
Changes since v3: * Leave the --super-prefix changes aside for now. As discussed in the v3 follow-up, now we're only removing the unused $prefix variable. Since the v2 was submitted Glen's submitted a series of his own. I think any non-trivial updates to --super-prefix are better done there, as noted in: https://lore.kernel.org/git/220628.86wnd1f9t1.gmgdl@evledraar.gmail.com/ (local) The overall diffstat is much smaller as a result, and I think this series should be ready for "next" now, as the remaining changes are well-revieweda at this point, with no outstanding issues.
Agreed. Since we no longer touch "--super-prefix", I think there aren't any remaining concerns. In v3, I was slightly concerned that we didn't fully understand the rationale behind "--super-prefix" before changing it, but I still gave that version my Reviewed-by because I'm convinced that the "--super-prefix" check isn't doing anything useful (and can be annoyingly overzealous).