Thread (105 messages) 105 messages, 4 authors, 2022-03-08

Re: [PATCH v3 08/10] submodule: move logic into fetch_task_create()

From: Jonathan Tan <hidden>
Date: 2022-02-24 23:36:10

Glen Choo [off-list ref] writes:
I think this patch could be squashed into the previous one, let me know
if this is a good idea.
For what it's worth, as a reviewer, I appreciated this patch being its
own. It made it easier to review.

It's unfortunate that the created diff has fetch_task_create() deleted
and readded, but showing it with

  --anchored=" memset(task, 0, sizeof(*task));"

does make it easier to see. (The space before memset is a tab.)
+ cleanup:
+	fetch_task_release(task);
+	free(task);
+	return NULL;
+}
No space between the left margin and "cleanup".

Otherwise, up to and including this patch looks good.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help