Thread (105 messages) 105 messages, 4 authors, 2022-03-08

Re: [PATCH v3 02/10] t5526: stop asserting on stderr literally

From: Eric Sunshine <hidden>
Date: 2022-02-24 18:13:45

On Thu, Feb 24, 2022 at 11:46 AM Glen Choo [off-list ref] wrote:
Ævar Arnfjörð Bjarmason [off-list ref] writes:
quoted
On Thu, Feb 24 2022, Glen Choo wrote:
quoted
+    sed -E 's/[0-9a-f]+\.\./OLD_HEAD\.\./' $ACTUAL_ERR >actual.err.cmp &&
I think this is unportable per check-non-portable-shell.pl:

        /\bsed\s+-[^efn]\s+/ and err 'sed option not portable (use only -n, -e, -f)';
I used that because I wanted +, but I found what I needed from the sed
manpage i.e. that + is equivalent to \{1,\}).
This isn't necessarily going to be portable either for older sed
implementations. Most portable would be:

    [0-9a-f][0-9a-f]*

(Whether or not we need to worry about those older sed impmenetations
is a different question...)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help