Re: [PATCH] gitk: fix error when resizing gitk

On Wed, 23 Feb 2022 16:03:55 +0100
Halil SEN [off-list ref] wrote:

Hello Shulhan,

Hi Halil,

I just stumbled upon your patch while looking for the patch
that I sent at the beginning of this week for the exact same
issue.  It turns out you sent your patch two months ago.  I
should have checked before debugging :face_palm:

If you would like to check it out, here is my patch in [1].

I see that you have fixed resizeclistpanes but exact same issue
is present on resizecdetpanes as well.

I have never encounter this issue.

I am not sure if the conditional logic is necessary because we
are sure that `sash#` includes x, y positions in ttk mode but it
includes only the x position if not ttk. Also setting the y coord
to 0 might have unintended consequences.

I am new to Tcl/Tk at the time fixing this issue, so it kinda
try-and-error-patch with printf here and there.  Your patch is more
simple and fix the issue too.

[1]
https://lore.kernel.org/git/0b5b8fb591e434a2a24b1f58d1ce3fc7da48a28e.1645386457.git.gitgitgadget@gmail.com/ (local)

Signed-off-by: Halil Sen <redacted>

-- 
{ "github":"github.com/shuLhan", "site":"kilabit.info" }