Thread (3 messages) flat view 3 messages, 2 authors, 2022-02-23

Re: [PATCH] gitk: fix error when resizing gitk

From: Halil SEN <hidden>
Date: 2022-02-23 15:04:10

Hello Shulhan,

I just stumbled upon your patch while looking for the patch
that I sent at the beginning of this week for the exact same
issue.  It turns out you sent your patch two months ago.  I
should have checked before debugging :face_palm:

If you would like to check it out, here is my patch in [1].

I see that you have fixed resizeclistpanes but exact same issue
is present on resizecdetpanes as well.

I am not sure if the conditional logic is necessary because we
are sure that `sash#` includes x, y positions in ttk mode but it
includes only the x position if not ttk. Also setting the y coord
to 0 might have unintended consequences.


[1] https://lore.kernel.org/git/0b5b8fb591e434a2a24b1f58d1ce3fc7da48a28e.1645386457.git.gitgitgadget@gmail.com/ (local)

Signed-off-by: Halil Sen <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help