Thread (2 messages) flat view 2 messages, 2 authors, 2021-12-22

Re: [PATCH v3] fast-export: fix surprising behavior with --first-parent

From: Junio C Hamano <hidden>
Date: 2021-12-21 20:51:07

Elijah Newren [off-list ref] writes:
quoted
     * Changed commit message to include the detailed description of the
       problem area as suggested by Elijah. I went back and forth with my
       self about whether the message needs some "lead in", but it ended up
       getting long without adding much.
If it feels weird quoting someone else so extensively and just using
their words for the commit message, we've used a "Commit-message-by:"
trailer in the past; that could be useful here.
I do not mind tweaking the copy I already have with "Helped-by"
myself, while ...
This version looks good to me:

Reviewed-by: Elijah Newren <redacted>
... adding this one before merging the result to 'next'.

Thanks, both.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help