Re: [PATCH v3] fast-export: fix surprising behavior with --first-parent

Elijah Newren [off-list ref] writes:

quoted

     * Changed commit message to include the detailed description of the
       problem area as suggested by Elijah. I went back and forth with my
       self about whether the message needs some "lead in", but it ended up
       getting long without adding much.

If it feels weird quoting someone else so extensively and just using
their words for the commit message, we've used a "Commit-message-by:"
trailer in the past; that could be useful here.

I do not mind tweaking the copy I already have with "Helped-by"
myself, while ...

This version looks good to me:

Reviewed-by: Elijah Newren <redacted>

... adding this one before merging the result to 'next'.

Thanks, both.

On 21/12/2021 21.50, Junio C Hamano wrote:

Elijah Newren [off-list ref] writes:

quoted

quoted

      * Changed commit message to include the detailed description of the
        problem area as suggested by Elijah. I went back and forth with my
        self about whether the message needs some "lead in", but it ended up
        getting long without adding much.

If it feels weird quoting someone else so extensively and just using
their words for the commit message, we've used a "Commit-message-by:"
trailer in the past; that could be useful here.

I do not mind tweaking the copy I already have with "Helped-by"
myself, while ...

quoted

This version looks good to me:

Reviewed-by: Elijah Newren <redacted>

... adding this one before merging the result to 'next'.

Thanks, both.

Either way works for me. I'm not too familiar with conventions around 
trailers. Both seem very reasonable to me.

Thanks a bunch for the help. :)