[PATCH v2 03/11] reftable: fix resource leak blocksource.c
STALE1651d
From: Han-Wen Nienhuys via GitGitGadget <hidden>
Date: 2021-12-08 21:49:56
Subsystem:
the rest · Maintainer:
Linus Torvalds
Revision v2 of 7 in this series.
Revisions (7)
From: Han-Wen Nienhuys <redacted> This would be triggered in the unlikely event of fstat() failing on an opened file. Signed-off-by: Han-Wen Nienhuys <redacted> --- reftable/blocksource.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/reftable/blocksource.c b/reftable/blocksource.c
index 0044eecd9aa..2605371c28d 100644
--- a/reftable/blocksource.c
+++ b/reftable/blocksource.c@@ -134,8 +134,10 @@ int reftable_block_source_from_file(struct reftable_block_source *bs, } err = fstat(fd, &st); - if (err < 0) - return -1; + if (err < 0) { + close(fd); + return REFTABLE_IO_ERROR; + } p = reftable_calloc(sizeof(struct file_block_source)); p->size = st.st_size;
--
gitgitgadget