Thread (145 messages) flat view 145 messages, 7 authors, 2022-03-29

Re: [PATCH v3 09/11] reftable: drop stray printf in readwrite_test

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-12-13 16:27:02

On Mon, Dec 13 2021, Han-Wen Nienhuys via GitGitGadget wrote:
quoted hunk ↗ jump to hunk
From: Han-Wen Nienhuys <redacted>

Signed-off-by: Han-Wen Nienhuys <redacted>
---
 reftable/readwrite_test.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/reftable/readwrite_test.c b/reftable/readwrite_test.c
index 42caf0bde4c..f6546d7b8d1 100644
--- a/reftable/readwrite_test.c
+++ b/reftable/readwrite_test.c
@@ -663,7 +663,6 @@ static void test_write_key_order(void)
 	err = reftable_writer_add_ref(w, &refs[0]);
 	EXPECT_ERR(err);
 	err = reftable_writer_add_ref(w, &refs[1]);
-	printf("%d\n", err);
 	EXPECT(err == REFTABLE_API_ERROR);
 	reftable_writer_close(w);
 	reftable_writer_free(w);
Is this something coverity raised and I'm missing why it's bad (per the
CL), or just a stray unrelated cleanup?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help