Re: [PATCH v14 2/3] am: support --empty=<option> to handle empty patches
flat view
From: Johannes Schindelin <hidden>
Date: 2021-12-03 22:33:59
Hi Aleen, On Wed, 1 Dec 2021, 徐沛文 (Aleen) via GitGitGadget wrote:
quoted hunk ↗ jump to hunk
diff --git a/Documentation/git-am.txt b/Documentation/git-am.txt index 0a4a984dfde..cf9cace9678 100644 --- a/Documentation/git-am.txt +++ b/Documentation/git-am.txt@@ -16,6 +16,7 @@ SYNOPSIS [--exclude=<path>] [--include=<path>] [--reject] [-q | --quiet] [--[no-]scissors] [-S[<keyid>]] [--patch-format=<format>] [--quoted-cr=<action>] + [--empty=(die|drop|keep)]
I have to agree with Elijah that "to die" is used differently in Git's context. This should probably be called "stop" instead. Or "error". But not "die". Ciao, Dscho P.S.: The enum value should probably have an `_ON_` in it, i.e. `STOP_ON_EMPTY_COMMIT` or `ERROR_ON_EMPTY_COMMIT`.