Thread (97 messages) 97 messages, 11 authors, 2021-12-11

Re: [PATCH v6 2/3] am: support --empty option to handle empty patches

flat view

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-11-19 12:12:52

On Fri, Nov 19 2021, Bagas Sanjaya wrote:
On 18/11/21 17.50, Aleen via GitGitGadget wrote:
quoted
+test_expect_success 'still output error with --empty when meeting empty files' '
+	test_must_fail git am --empty=drop empty.patch 2>actual &&
+	echo Patch format detection failed. >expected &&
+	test_cmp expected actual
+'
Why isn't the echo string quoted?
There's no need to quote the arguments given to echo in cases like
these.

It's not the same, i.e. it'll get N arguments on argv and not on, but it
makes it easier to spot things that do need quoting, rather than
over-quoting everything.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help