Re: [PATCH v1 3/3] difftool: add space after full stop in comments
From: David Aguilar <hidden>
Date: 2021-10-11 15:43:18
On Sat, Oct 2, 2021 at 11:49 AM Andrei Rybak [off-list ref] wrote:
quoted hunk ↗ jump to hunk
These punctuation typos were found using: git grep -P ' [a-z0-9A-Z-]+[.][A-Z][A-Za-z-]+ ' Signed-off-by: Andrei Rybak <redacted> --- I've also looked for similar typos around commas and semicolons and didn't find any. builtin/difftool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/builtin/difftool.c b/builtin/difftool.c index bb9fe7245a..d9a4e55caf 100644 --- a/builtin/difftool.c +++ b/builtin/difftool.c@@ -529,7 +529,7 @@ static int run_dir_diff(const char *extcmd, int symlinks, const char *prefix, goto finish; /* - * Changes to submodules require special treatment.This loop writes a + * Changes to submodules require special treatment. This loop writes a * temporary file to both the left and right directories to show the * change in the recorded SHA1 for the submodule. */@@ -548,7 +548,7 @@ static int run_dir_diff(const char *extcmd, int symlinks, const char *prefix, } /* - * Symbolic links require special treatment.The standard "git diff" + * Symbolic links require special treatment. The standard "git diff" * shows only the link itself, not the contents of the link target. * This loop replicates that behavior. */
Heads-up -- this 2nd hunk is already in "next". Please see: 28c10ecbfc (difftool: add a missing space to the run_dir_diff() comments, 2021-09-30) The 1st hunk above it (submodules) is still relevant. It might be worth rebasing this patch against the da/difftool topic in "next". This patch should become a one-liner once that's done. -- David