Thread (11 messages) flat view 11 messages, 5 authors, 2021-10-11

Re: [PATCH v1 3/3] difftool: add space after full stop in comments

From: Carlo Arenas <hidden>
Date: 2021-10-02 20:16:24

On Sat, Oct 2, 2021 at 12:38 PM Elijah Newren [off-list ref] wrote:
On Sat, Oct 2, 2021 at 11:49 AM Andrei Rybak [off-list ref] wrote:
quoted
These punctuation typos were found using:

    git grep -P ' [a-z0-9A-Z-]+[.][A-Z][A-Za-z-]+ '
While Junio has commented that two spaces after the full stop in
fixed-width source code viewing looks better, and I personally prefer
that style as well, I don't think these are worth "fixing".
FWIW those are not adding a second space, but adding ANY space between
a "." and beginning of the next sentence.
you separated this from the other changes, but I'd rather see this
patch dropped.
While I don't think encouraging this kind of "fixes" might make sense,
the work was already done and the "churn" is very small (only 2 places
out of ~2K), where we have in the codebase: ".<space><space>"

Carlo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help