Thread (59 messages) flat view 59 messages, 7 authors, 2021-10-15

Re: [PATCH v2 0/3] Use default values from settings instead of config

From: Glen Choo <hidden>
Date: 2021-09-29 22:53:39

Eric Sunshine [off-list ref] writes:
I re-read the entire thread and left a few comments on the v2 patches.
One or two of the comments might be actionable (i.e. deserve a
re-roll), but most are probably subjective.
Thanks so much again!
Oh, I forgot to mention in my review of [3/3] that in:

    In the case where core.multiPackIndex is not set in the config, the auto
    condition would fail, causing the incremental-repack task to not be
    run. Because we always want to consider the default values, we should
    just always just use the_repository->settings.

you can probably drop one or both "just"s.
Yes, this is definitely a typo from me.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help