Thread (59 messages) flat view 59 messages, 7 authors, 2021-10-15

Re: [PATCH 3/3] gc: perform incremental repack when implictly enabled

From: Taylor Blau <hidden>
Date: 2021-09-13 19:37:29

On Mon, Sep 13, 2021 at 11:12:21AM -0700, Glen Choo wrote:
builtin/gc.c has two ways of checking of multi-pack-index is enabled:
- git_config_get_bool() in incremental_repack_auto_condition()
- the_repository->settings.core_multi_pack_index in
  maintenance_task_incremental_repack()
Is this hinting at why there are no new tests added here? If so, it may
need to be explained more clearly, since I was a tad confused after
reading it. But if not, this patch message deserves an extra sentence or
two saying why tests aren't necessary.

Or if none of that is the case, and tests *are* necessary, then they
should be added ;).

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help