Thread (138 messages) flat view 138 messages, 9 authors, 2022-03-10

Re: [PATCH v5 4/7] update-index: use the bulk-checkin infrastructure

From: Neeraj Singh <hidden>
Date: 2021-09-24 21:49:45

On Fri, Sep 24, 2021 at 1:12 PM Neeraj Singh via GitGitGadget
[off-list ref] wrote:
From: Neeraj Singh <redacted>

The update-index functionality is used internally by 'git stash push' to
setup the internal stashed commit.

This change enables bulk-checkin for update-index infrastructure to
speed up adding new objects to the object database by leveraging the
pack functionality and the new bulk-fsync functionality. This mode
is enabled when passing paths to update-index via the --stdin flag,
as is done by 'git stash'.
This part of the description is now inaccurate. All modes of update-index are
now enlightened to use bulk_checkin. I'll just remove the sentence that
scopes the change to --stdin on reroll.
There is some risk with this change, since under batch fsync, the object
files will not be available until the update-index is entirely complete.
This usage is unlikely, since any tool invoking update-index and
expecting to see objects would have to synchronize with the update-index
process after passing it a file path.

Signed-off-by: Neeraj Singh <redacted>
---
 builtin/update-index.c | 6 ++++++
 1 file changed, 6 insertions(+)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help