Thread (82 messages) flat view 82 messages, 11 authors, 2021-09-23

Re: [PATCH] fixup! tests: add a test mode for SANITIZE=leak, run it in CI

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-09-23 02:06:13

On Wed, Sep 22 2021, Carlo Marcelo Arenas Belón wrote:
runs cleanly in seen as shown by :

  https://github.com/carenas/git/runs/3673976105

previously failing in the extended checks as shown at at least by :

  https://github.com/git/git/runs/3657308323
Thanks, it broke because it combined with sg/test-split-index-fix,
running the test with GIT_TEST_SPLIT_INDEX=true reveals a memory leak
that we weren't testing until then.

Junio: I think just applying this fixup is the right thing for now, are
you willing to do that or should I submit a re-roll with it?
quoted hunk ↗ jump to hunk
Signed-off-by: Carlo Marcelo Arenas Belón <redacted>
---
 t/t0016-oidmap.sh | 1 -
 1 file changed, 1 deletion(-)
diff --git a/t/t0016-oidmap.sh b/t/t0016-oidmap.sh
index 0faef1f4f1..f81aa9ea03 100755
--- a/t/t0016-oidmap.sh
+++ b/t/t0016-oidmap.sh
@@ -2,7 +2,6 @@
 
 test_description='test oidmap'
 
-TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 # This purposefully is very similar to t0011-hashmap.sh
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help