Re: [PATCH v2 0/4] add a test mode for SANITIZE=leak, run it in CI

On 14/07/2021 19:23, Ævar Arnfjörð Bjarmason wrote:

As a follow-up to my recent thread asking if we had some test mode or
CI to test for memory leak regression (we don't), add such a test
mode, and run it in CI.

Currently the two new CI targets take ~2-3 minutes to run in GitHub
CI, whereas the normal test targets take 20-30 minutes. The tests run
slower, but we have a small whitelist of test scripts that are OK.

v2:

  * Fixes issues spotted by Đoàn Trần Công Danh and Eric Sunshine,
    thanks both!

  * I got rid of the change to t0500, I saw it being flaky in GitHub
    CI, and looks like there'll be other concurrent edits to that file,
    so leaving it be.

v1: http://lore.kernel.org/git/cover-0.4-0000000000-20210714T001007Z-avarab@gmail.com (local)

Ævar Arnfjörð Bjarmason (4):
   tests: add a test mode for SANITIZE=leak, run it in CI
   SANITIZE tests: fix memory leaks in t13*config*, add to whitelist
   SANITIZE tests: fix memory leaks in t5701*, add to whitelist
   SANITIZE tests: fix leak in mailmap.c

The leak fixes look good to me, modulo the UNLEAK as already commented 
on in patch 2/4 - thank you!

I don't feel qualified to review the test and CI related scripting, 
hopefully someone else will be able to look at those changes :).

ATB,

Andrzej

[...snip...]