[PATCH v2 0/5] repo-settings.c: refactor for clarity, get rid of hacks etc. · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-16
[PATCH v2 1/5] wrapper.c: add x{un,}setenv(), and use xsetenv() in environment.c · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-16
[PATCH v2 2/5] environment.c: remove test-specific "ignore_untracked..." variable · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-16
[PATCH v2 3/5] read-cache & fetch-negotiator: check "enum" values in switch() · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-16
[PATCH v2 5/5] repository.h: don't use a mix of int and bitfields · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-16
[PATCH v2 4/5] repo-settings.c: simplify the setup · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-16
[PATCH v3 0/5] repo-settings.c: refactor for clarity, get rid of hacks etc. · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-19
[PATCH v3 2/5] environment.c: remove test-specific "ignore_untracked..." variable · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-19
Re: [PATCH v3 2/5] environment.c: remove test-specific "ignore_untracked..." variable · Taylor Blau <hidden> · 2021-09-21
Re: [PATCH v3 2/5] environment.c: remove test-specific "ignore_untracked..." variable · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v3 1/5] wrapper.c: add x{un,}setenv(), and use xsetenv() in environment.c · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-19
Re: [PATCH v3 1/5] wrapper.c: add x{un,}setenv(), and use xsetenv() in environment.c · Taylor Blau <hidden> · 2021-09-21
Re: [PATCH v3 1/5] wrapper.c: add x{un,}setenv(), and use xsetenv() in environment.c · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v3 3/5] read-cache & fetch-negotiator: check "enum" values in switch() · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-19
Re: [PATCH v3 3/5] read-cache & fetch-negotiator: check "enum" values in switch() · Taylor Blau <hidden> · 2021-09-21
Re: [PATCH v3 3/5] read-cache & fetch-negotiator: check "enum" values in switch() · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v3 5/5] repository.h: don't use a mix of int and bitfields · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-19
Re: [PATCH v3 5/5] repository.h: don't use a mix of int and bitfields · Taylor Blau <hidden> · 2021-09-21
[PATCH v3 4/5] repo-settings.c: simplify the setup · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-19
Re: [PATCH v3 4/5] repo-settings.c: simplify the setup · Derrick Stolee <hidden> · 2021-09-20
Re: [PATCH v3 4/5] repo-settings.c: simplify the setup · Taylor Blau <hidden> · 2021-09-21
[PATCH v4 0/5] repo-settings.c: refactor for clarity, get rid of hacks etc. · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v4 1/5] wrapper.c: add x{un,}setenv(), and use xsetenv() in environment.c · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v4 2/5] environment.c: remove test-specific "ignore_untracked..." variable · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v4 3/5] read-cache & fetch-negotiator: check "enum" values in switch() · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v4 4/5] repo-settings.c: simplify the setup · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v4 5/5] repository.h: don't use a mix of int and bitfields · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
Re: [PATCH v4 0/5] repo-settings.c: refactor for clarity, get rid of hacks etc. · Derrick Stolee <hidden> · 2021-09-21
Re: [PATCH v4 0/5] repo-settings.c: refactor for clarity, get rid of hacks etc. · Taylor Blau <hidden> · 2021-09-21

Re: [PATCH v4 0/5] repo-settings.c: refactor for clarity, get rid of hacks etc.

From: Taylor Blau <hidden>
Date: 2021-09-21 20:46:53

On Tue, Sep 21, 2021 at 11:58:34AM -0400, Derrick Stolee wrote:

On 9/21/2021 9:12 AM, Ævar Arnfjörð Bjarmason wrote:

quoted

A hopefully final re-roll addressing Taylor's v3 review, except for
the suggestion (that I read as) perhaps retaining the test-only code,
which I've decided not to do per
http://lore.kernel.org/git/87tuieakms.fsf@evledraar.gmail.com (local)

[...]

This version looks good to me.

Likewise. Thanks Ævar for addressing my review.

    Reviewed-by: Taylor Blau [off-list ref]

Thanks,
Taylor

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help