[PATCH v2 0/5] repo-settings.c: refactor for clarity, get rid of hacks etc. · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-16
[PATCH v2 1/5] wrapper.c: add x{un,}setenv(), and use xsetenv() in environment.c · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-16
[PATCH v2 2/5] environment.c: remove test-specific "ignore_untracked..." variable · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-16
[PATCH v2 3/5] read-cache & fetch-negotiator: check "enum" values in switch() · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-16
[PATCH v2 5/5] repository.h: don't use a mix of int and bitfields · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-16
[PATCH v2 4/5] repo-settings.c: simplify the setup · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-16
[PATCH v3 0/5] repo-settings.c: refactor for clarity, get rid of hacks etc. · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-19
[PATCH v3 2/5] environment.c: remove test-specific "ignore_untracked..." variable · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-19
Re: [PATCH v3 2/5] environment.c: remove test-specific "ignore_untracked..." variable · Taylor Blau <hidden> · 2021-09-21
Re: [PATCH v3 2/5] environment.c: remove test-specific "ignore_untracked..." variable · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v3 1/5] wrapper.c: add x{un,}setenv(), and use xsetenv() in environment.c · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-19
Re: [PATCH v3 1/5] wrapper.c: add x{un,}setenv(), and use xsetenv() in environment.c · Taylor Blau <hidden> · 2021-09-21
Re: [PATCH v3 1/5] wrapper.c: add x{un,}setenv(), and use xsetenv() in environment.c · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v3 3/5] read-cache & fetch-negotiator: check "enum" values in switch() · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-19
Re: [PATCH v3 3/5] read-cache & fetch-negotiator: check "enum" values in switch() · Taylor Blau <hidden> · 2021-09-21
Re: [PATCH v3 3/5] read-cache & fetch-negotiator: check "enum" values in switch() · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v3 5/5] repository.h: don't use a mix of int and bitfields · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-19
Re: [PATCH v3 5/5] repository.h: don't use a mix of int and bitfields · Taylor Blau <hidden> · 2021-09-21
[PATCH v3 4/5] repo-settings.c: simplify the setup · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-19
Re: [PATCH v3 4/5] repo-settings.c: simplify the setup · Derrick Stolee <hidden> · 2021-09-20
Re: [PATCH v3 4/5] repo-settings.c: simplify the setup · Taylor Blau <hidden> · 2021-09-21
[PATCH v4 0/5] repo-settings.c: refactor for clarity, get rid of hacks etc. · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v4 1/5] wrapper.c: add x{un,}setenv(), and use xsetenv() in environment.c · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v4 2/5] environment.c: remove test-specific "ignore_untracked..." variable · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v4 3/5] read-cache & fetch-negotiator: check "enum" values in switch() · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v4 4/5] repo-settings.c: simplify the setup · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
[PATCH v4 5/5] repository.h: don't use a mix of int and bitfields · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
Re: [PATCH v4 0/5] repo-settings.c: refactor for clarity, get rid of hacks etc. · Derrick Stolee <hidden> · 2021-09-21
Re: [PATCH v4 0/5] repo-settings.c: refactor for clarity, get rid of hacks etc. · Taylor Blau <hidden> · 2021-09-21

Re: [PATCH v3 4/5] repo-settings.c: simplify the setup

From: Derrick Stolee <hidden>
Date: 2021-09-20 12:42:42

On 9/19/2021 4:47 AM, Ævar Arnfjörð Bjarmason wrote:

Simplify the setup code in repo-settings.c in various ways, making the
code shorter, easier to read, and requiring fewer hacks to do the same
thing as it did before:

Popping in here to say that I agree this new arrangement is cleaner.

The previous patterns were confusing, and probably led to at least one bug,
including one in the builtin FS Monitor shipped with git-for-windows/git [1]
where enabling features.experimental overrides core.useBuiltinFSMonitor=false.
The newer organization should make it harder for mistakes like that to happen.

Thanks,
-Stolee

[1] https://github.com/git-for-windows/git/discussions/3251#discussioncomment-1296896

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help