Thread (30 messages) 30 messages, 7 authors, 2021-09-24

Re: [PATCH 4/5] grep: mark "haystack" buffers as const

flat view

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-09-21 12:05:43

On Mon, Sep 20 2021, Jeff King wrote:
quoted hunk ↗ jump to hunk
-static int patmatch(struct grep_pat *p, char *line, char *eol,
+static int patmatch(struct grep_pat *p,
+		    const char *line, const char *eol,
 		    regmatch_t *match, int eflags)
nit; not worth a re-roll, over-line-wrapping here? You usually stay at
column 79. In this case both line and eol would fit on the patmatch()
lin, which is being changed anyway...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help