[PATCH 0/5] const-correctness in grep.c · Jeff King <hidden> · 2021-09-21
[PATCH 1/5] grep: stop modifying buffer in strip_timestamp · Jeff King <hidden> · 2021-09-21
Re: [PATCH 1/5] grep: stop modifying buffer in strip_timestamp · Carlo Arenas <hidden> · 2021-09-21
Re: [PATCH 1/5] grep: stop modifying buffer in strip_timestamp · Eric Sunshine <hidden> · 2021-09-21
Re: [PATCH 1/5] grep: stop modifying buffer in strip_timestamp · Carlo Arenas <hidden> · 2021-09-21
Re: [PATCH 1/5] grep: stop modifying buffer in strip_timestamp · Jeff King <hidden> · 2021-09-21
Re: [PATCH 1/5] grep: stop modifying buffer in strip_timestamp · Carlo Marcelo Arenas Belón <hidden> · 2021-09-21
Re: [PATCH 1/5] grep: stop modifying buffer in strip_timestamp · René Scharfe <hidden> · 2021-09-21
Re: [PATCH 1/5] grep: stop modifying buffer in strip_timestamp · Jeff King <hidden> · 2021-09-21
Re: [PATCH 1/5] grep: stop modifying buffer in strip_timestamp · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
Re: [PATCH 1/5] grep: stop modifying buffer in strip_timestamp · Jeff King <hidden> · 2021-09-22
Re: [PATCH 1/5] grep: stop modifying buffer in strip_timestamp · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-23
[PATCH 2/5] grep: stop modifying buffer in show_line() · Jeff King <hidden> · 2021-09-21
Re: [PATCH 2/5] grep: stop modifying buffer in show_line() · Taylor Blau <hidden> · 2021-09-21
Re: [PATCH 2/5] grep: stop modifying buffer in show_line() · Jeff King <hidden> · 2021-09-21
Re: [PATCH 2/5] grep: stop modifying buffer in show_line() · Taylor Blau <hidden> · 2021-09-21
[PATCH 3/5] grep: stop modifying buffer in grep_source_1() · Jeff King <hidden> · 2021-09-21
[PATCH 4/5] grep: mark "haystack" buffers as const · Jeff King <hidden> · 2021-09-21
Re: [PATCH 4/5] grep: mark "haystack" buffers as const · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
Re: [PATCH 4/5] grep: mark "haystack" buffers as const · Jeff King <hidden> · 2021-09-21
[PATCH 5/5] grep: store grep_source buffer as const · Jeff King <hidden> · 2021-09-21
Re: [PATCH 0/5] const-correctness in grep.c · Taylor Blau <hidden> · 2021-09-21
Re: [PATCH 0/5] const-correctness in grep.c · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
Re: [PATCH 0/5] const-correctness in grep.c · Jeff King <hidden> · 2021-09-21
[PATCH 6/5] grep.c: mark eol/bol and derived as "const char * const" · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
Re: [PATCH 6/5] grep.c: mark eol/bol and derived as "const char * const" · Jeff King <hidden> · 2021-09-21
Re: [PATCH 6/5] grep.c: mark eol/bol and derived as "const char * const" · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-21
Re: [PATCH 6/5] grep.c: mark eol/bol and derived as "const char * const" · Jeff King <hidden> · 2021-09-21
Re: [PATCH 6/5] grep.c: mark eol/bol and derived as "const char * const" · Ævar Arnfjörð Bjarmason <hidden> · 2021-09-23
Re: [PATCH 6/5] grep.c: mark eol/bol and derived as "const char * const" · Junio C Hamano <hidden> · 2021-09-24

Re: [PATCH 1/5] grep: stop modifying buffer in strip_timestamp

From: Carlo Arenas <hidden>
Date: 2021-09-21 05:18:41

On Mon, Sep 20, 2021 at 9:09 PM Jeff King [off-list ref] wrote:

quoted hunk ↗ jump to hunk

@@ -971,7 +966,7 @@ static int match_one_pattern(struct grep_pat *p, char *bol, char *eol,
                switch (p->field) {
                case GREP_HEADER_AUTHOR:
                case GREP_HEADER_COMMITTER:
-                       saved_ch = strip_timestamp(bol, &eol);
+                       strip_timestamp(bol, &eol);

Why not something like (plus added error handling, even if it seems
the original didn't have them)?

  eol = strrchr(bol, '>');

Carlo

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help