Re: [PATCH 0/5] post-v2.33 "drop support for ancient curl" follow-up

On Wed, Sep 08, 2021 at 05:31:51PM +0200, Ævar Arnfjörð Bjarmason wrote:

This is a follow-up to the already-integrated topic for dropping
support for older curl versions submitted before the v2.33 release[1].

No verions become unsupported in this topic, this is a mere clean-up.

There were a couple of cases where we either already dropped support
for something, but got the curl version wrong in a macro comparison,
or just got the version wrong. That's now corrected.

But more importantly this introduces a git-curl-compat.h header which
centarlizes all our curl version dependencies, and any compatability
shims we've got to deal with those versions. This makes the code much
easier to read and maintain than inline LIBCURL_VERSION_NUM version
comparisons, and will make any future dropping of supported curl
versions in the future easier to perform & review.

These all seem fine to me. I left a few comments that are mostly
thinking out loud, not really asking for any changes.

-Peff