Re: [PATCH 2/4] http: drop support for curl < 7.16.0

On Wed, Aug 09, 2017 at 10:29:04AM -0700, Stefan Beller wrote:

quoted

 Documentation/config.txt |  3 +--
 http-push.c              | 23 --------------------
 http-walker.c            | 12 -----------
 http.c                   | 56 +-----------------------------------------------
 http.h                   | 20 +----------------
 remote-curl.c            |  4 ----
 6 files changed, 3 insertions(+), 115 deletions(-)

`git grep USE_CURL_MULTI` also yields
Documentation/config.txt
t/t5540-http-push-webdav.sh

Would these also need adaption in this patch?

That one threw me off for a minute. How does a test even know about
USE_CURL_MULTI?

But it is just a bad error message. :) You cannot fix it by compiling
with "make USE_CURL_MULTI=1". The right message is more like "skipping
http-push tests, your curl is too old".

But that does mean there's another problem: Makefile can drop its
conditional curl_check for http-push.o. I'll add that to a re-roll.

-Peff