Re: [PATCH v3 2/6] hook: allow parallel hook execution

On Tue, Aug 24, 2021 at 11:06 AM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:

On Wed, Aug 18 2021, Emily Shaffer wrote:

quoted

+'git hook' run [--to-stdin=<path>] [--ignore-missing] [(-j|--jobs) <n>]
+     <hook-name> [-- <hook-args>]

As an aside I wondered if it shouldn't be [[-j|--jobs] <n>], but grepped
around and found that (x|y|z) means a mandatory pick of x, y or z, but
[x|y|z] means that, plus possibly picking none, I think.

So this is fine, just something I wondered about...

Indeed, the text is fine as-is.

quoted

+Specify how many hooks to run simultaneously. If this flag is not specified, use
+the value of the `hook.jobs` config. If the config is not specified, use the

s/use the value/uses the value/

As a native English speaker, the text as written (even if a bit
stilted) sounds better than the suggested replacement. A small tweak
might improve it slightly:

    If this flag is not specified, the value of the `hooks.job`
    configuration is used instead (see linkgit:git-config[1]).

but is not at all worth a re-roll or a lot of discussion.

Also we usually say "of the XYZ config, see linkgit:git-config[1]", or
something to that effect when we mention config variables. Perhaps we
should do the same here.