Re: [PATCH 00/31] minimal restart of "config-based-hooks"
From: Felipe Contreras <hidden>
Date: 2021-06-02 05:31:02
Emily Shaffer wrote:
On Fri, May 28, 2021 at 02:11:02PM +0200, Ævar Arnfjörð Bjarmason wrote:quoted
After suggesting[1] an another round that the config-based-hook topic[2] should take a more incremental approach to reach its end goal I thought I'd try hacking that up. So this is a proposed restart of that topic which if the consensus favors it should replace it, and the config-based hooks topic should be rebased on top of this.I'm not entirely sure what you're trying to achieve by sending this series.
Have a better review? By having a more reviwable series?
It was my impression that the existing config-based-hooks topic was close to being ready to submit anyway (since Junio mentioned submitting it a couple revisions ago); rather than churning by reviewing a different 31-patch topic, and then re-rolling and re-reviewing a (reduced) config hook topic, wouldn't it be easier on everyone's time to do a final incremental review on the existing topic and then start in on bugfixes/feature patches afterwards?
Not to me. I tried to review your series and I just couldn't. Maybe it's something about me, but the whole point of a review is to have as many eyes as possible on the code in order to spot any potential issues. If some eyes have trouble parsing the patches, that's not optimal. Ævar's approach is easy for me to follow.
It would have been nice to see a more clear discussion of patch organization sometime much sooner in the past year and a half since the project was proposed[3], like maybe in the few iterations of the design doc which included a rollout plan in July of last year[4].
Not all of us are being paid by a big corporation to work on Git. Some of us are doing the work on our own free time. You can't demand we spend our own free time on a certain patch series as soon as possible because it's more convenient for $corporation. Git is an open source community project.
To me, it seems late to be overhauling the direction like this, especially after I asked for opinions and approval on the direction before I started work in earnest.
To me it's completely the opposite; it's never too late to overwhaul a patch series. In my opinion you should be thankful that somebody took the time to try to improve your series *for free*. Cheers. -- Felipe Contreras