Re: [PATCH v4 2/6] t6030-bisect-porcelain: add test for bisect visualize

Hi Bagas,

El mar, 17 ago 2021 a las 11:03, Bagas Sanjaya
([off-list ref]) escribió:

On 17/08/21 15.14, Miriam Rubio wrote:

quoted

Add a test to control breakages in bisect visualize command.

Signed-off-by: Miriam Rubio <redacted>
---
  t/t6030-bisect-porcelain.sh | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh
index f41453cc97..99b7517400 100755
--- a/t/t6030-bisect-porcelain.sh
+++ b/t/t6030-bisect-porcelain.sh

@@ -976,4 +976,11 @@ test_expect_success 'bisect run fails with exit code smaller than 0' '
      test_must_fail git bisect run ./test_script.sh > my_bisect_log.txt
  '

+test_expect_success 'bisect visualize with a filename with dash and space' '
+     echo "My test line" >> -hello\ 2 &&
+     git add -- -hello\ 2 &&
+     git commit --quiet -m "Add test line" -- -hello\ 2 &&
+     git bisect visualize -p -- -hello\ 2 > my_bisect_log.txt
+'
+
  test_done

Seems like you're testing with filename with dash and space. Does git
bisect visualize have any problems handling such filenames?

It was a suggestion of a reviewer in the previous version to detect
possible breakages:
https://lore.kernel.org/git/xmqq35vwh8qk.fsf@gitster.g/ (local)

Thanks for reviewing,
Miriam

--
An old man doll... just what I always wanted! - Clara