Re: [PATCH v2 09/11] reflog expire: don't lock reflogs using previously seen OID
flat view
From: Han-Wen Nienhuys <hidden>
Date: 2021-08-17 13:35:18
On Fri, Jul 16, 2021 at 4:13 PM Ævar Arnfjörð Bjarmason [off-list ref] wrote:
quoted hunk ↗ jump to hunk
- status |= reflog_expire(e->reflog, &e->oid, flags, + status |= reflog_expire(e->reflog, NULL, flags, reflog_expiry_prepare,
this causes reflog_expiry_prepare() to be called with a NULL oid. I'm seeing a crash in do_lookup_replace_object() because of this in t0031-reftable.sh. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado