[PATCH v4 01/11] refs/packet: add missing BUG() invocations to reflog callbacks
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-07-26 23:44:40
Subsystem:
the rest · Maintainer:
Linus Torvalds
In e0cc8ac8202 (packed_ref_store: make class into a subclass of `ref_store`, 2017-06-23) a die() was added to packed_create_reflog(), but not to any of the other reflog callbacks, let's do that. Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- refs/packed-backend.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/refs/packed-backend.c b/refs/packed-backend.c
index f8aa97d799..24a360b719 100644
--- a/refs/packed-backend.c
+++ b/refs/packed-backend.c@@ -1600,6 +1600,7 @@ static int packed_for_each_reflog_ent(struct ref_store *ref_store, const char *refname, each_reflog_ent_fn fn, void *cb_data) { + BUG("packed reference store does not support reflogs"); return 0; }
@@ -1608,12 +1609,14 @@ static int packed_for_each_reflog_ent_reverse(struct ref_store *ref_store, each_reflog_ent_fn fn, void *cb_data) { + BUG("packed reference store does not support reflogs"); return 0; } static int packed_reflog_exists(struct ref_store *ref_store, const char *refname) { + BUG("packed reference store does not support reflogs"); return 0; }
@@ -1627,6 +1630,7 @@ static int packed_create_reflog(struct ref_store *ref_store, static int packed_delete_reflog(struct ref_store *ref_store, const char *refname) { + BUG("packed reference store does not support reflogs"); return 0; }
@@ -1638,6 +1642,7 @@ static int packed_reflog_expire(struct ref_store *ref_store, reflog_expiry_cleanup_fn cleanup_fn, void *policy_cb_data) { + BUG("packed reference store does not support reflogs"); return 0; }
--
2.32.0.956.g6b0c84ceda8